Date: Mon, 17 May 2010 14:04:24 -0700 From: Randall Stewart <rrs@lakerest.net> To: "C. Jayachandran" <c.jayachandran@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: Minor fixup for the MIPS SMP platform code. Message-ID: <728CDFF3-7EB8-4618-8805-EFD991ADCBC8@lakerest.net> In-Reply-To: <AANLkTim5HbGok2z8ZImgCvpBbMSWVx-G34YBTo9dPEUE@mail.gmail.com> References: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com> <AANLkTin1CmrTmuwChVnwBaSRsnQO8mcwE5P9fXBtPTvp@mail.gmail.com> <AANLkTim5HbGok2z8ZImgCvpBbMSWVx-G34YBTo9dPEUE@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
JC: Give me a few hours and I will get it in.. need to finish my work day first ;-0 R On May 17, 2010, at 10:38 AM, C. Jayachandran wrote: > On Mon, May 17, 2010 at 9:08 PM, Neel Natu <neelnatu@gmail.com> wrote: > Hi JC, > > Your patch looks good. Thanks for cleaning up the platform-specific > code from mp_machdep.c. > > There are a couple of style things you might want to take care of: > > 1. In hwfunc.h there is an extra space after the '*' in the > declaration of platform_smp_topo() > > 2. In platform_smp_topo() for XLR: > - Values in return statements should be enclosed in parantheses. > - space around binary operator '/' > > > Looks like I've been a bit sloppy here, updated patch attached, with > all the comments so far addressed. > > Thanks, > JC. > > > best > Neel > > On Mon, May 17, 2010 at 7:33 AM, C. Jayachandran > <c.jayachandran@gmail.com> wrote: > > The attached patch (also at > > http://sites.google.com/site/cjayachandran/files) has two changes: > > - moves the intr masking code to platform_init_ap, so that we can > avoid the > > #ifdef for XLR > > - adds a platform_smp_topo() function so that platforms can define > their > > topology > > > > I've also attempted to fixup sys/mips/sibyte to reflect these > changes, but > > it might need further work. > > sys/mips/cavium also might need similar changes for SMP. > > > > Please review and apply if the changes are okay. > > > > Thanks, > > JC. > > > > > > > > -- > C. Jayachandran c.jayachandran@gmail.com > <mips-smp-fixup.patch> ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?728CDFF3-7EB8-4618-8805-EFD991ADCBC8>