Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Mar 2015 15:11:25 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Adam Weinberger <adamw@adamw.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Bartek Rutkowski <robak@FreeBSD.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r381759 - head/graphics/synfigstudio
Message-ID:  <20150321151125.GD55163@FreeBSD.org>
In-Reply-To: <8E50A246-4542-4AEE-9A26-1FB112E531D7@adamw.org>
References:  <201503201818.t2KIIVe8076342@svn.freebsd.org> <20150321124707.GA39063@FreeBSD.org> <8E50A246-4542-4AEE-9A26-1FB112E531D7@adamw.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 21, 2015 at 09:05:24AM -0600, Adam Weinberger wrote:
> > On 21 Mar, 2015, at 6:47, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > Kato is known for introducing lots of worthless, stupid changes along his
> > "update to version xxx" PRs.  Please do not blindly apply these diffs as
> > not only they decrease STN ratio, cause unnecessary repo churn, and break
> > "svn blame", but are often against our established practices, thank you.
> 
> Kato does a ton of work to produce updates and fixes to more ports in one
> week than 3/4 the ports committers combined. If you're going to rail
> against an unpaid volunteer, do it on a closed list, not one that's
> archived at numerous points across the web.

I don't see how the fact of their numerous submissions should encourage us
to commit gratuitous changes that decrease STN ratio, cause unnecessary
repo churn, break "svn blame", and are often against our own established
practices.

> Trailing slashes look stupid and I often remove them when I update ports,
> even if it wasn't part of the original submission.

Trailing slashes should be used when they fit, and not used when they do
not, but this issue alone only tangential to what I'm talking about.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150321151125.GD55163>