Date: Fri, 27 Sep 2013 18:09:13 +0800 From: Julian Elischer <julian@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: Takuya ASADA <syuu@dokukino.com>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, hiren panchasara <hiren.panchasara@gmail.com> Subject: Re: Adding Flow Director sysctls to ixgbe(4) Message-ID: <52455949.5070501@freebsd.org> In-Reply-To: <CAJ-VmomUZ9cXBx2fJL9e6s73uR_XLSUWS_rj7ZLZ0Pey119i5Q@mail.gmail.com> References: <CALCpEUHcpoJoo_gqjyDzosE1bJ_J=o3uqUuyYJA8dWZdjMrNTA@mail.gmail.com> <CALG4x-UTpAKPs5VKAyqyFgSAHcCFAMtMjOUJJoYAaYQ1dW4pqA@mail.gmail.com> <CAJ-VmomUZ9cXBx2fJL9e6s73uR_XLSUWS_rj7ZLZ0Pey119i5Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/27/13 4:53 PM, Adrian Chadd wrote: > I don't care about whether there's a generic API right now. I'd rather see > it done as a staged thing, but _not_ sysctls. > > Having sysctls to add/remove entries from things is just plain evil. > > I'd rather instead come up with a device specific ioctl API for this for > now w/ a userland tool for each particular chip. Then once we all get a bit > more experience doing this, a unified API can be proposed. that makes it worse If you want to put a device specific sysctl/ioctl set out there then have a device INDEPENDENT tool that knows how to handle the devices we have modified and when we have enough examples we can change the ioctl/sysctl interface to a generic one without changing the interface people are using in their scripts. > > > -adrian > > > > On 27 September 2013 01:49, Takuya ASADA <syuu@dokukino.com> wrote: > >> Hi, >> >> I think there were many comment which says "don't use device specific >> sysctls, we should have more generic interface to configure NIC filter, >> like Linux's ethtool". >> And I heard same idea in last BSDCan, but there's still no proposal of >> "generic interface for NIC filter", I suppose. >> So, honestly I haven't good idea to merge the change. >> Is there any people who has good idea to handle this? >> >> Or, just merge this patch would be fine? >> >> >> 2013/9/27 hiren panchasara <hiren.panchasara@gmail.com> >> >>> >>> >>> On Thu, Sep 26, 2013 at 10:38 AM, hiren panchasara < >>> hiren.panchasara@gmail.com> wrote: >>> >>>> >>>> >>>> On Thu, Sep 26, 2013 at 12:58 AM, Michio Honda <micchie@outlook.com >>> wrote: >>>>> Hi, >>>>> >>>>> The handiest way to try flexible flow distribution is using Flow >>>>> Director. >>>>> I've confirmed that the patch posted to this list two years ago works >>>>> with netmap/ixgbe. >>>>> >>>>> >> http://freebsd.1045724.n5.nabble.com/Adding-Flow-Director-sysctls-to-ixgbe-4-td4769489.html >>>> Thanks a lot for the link, Michio! >>>> >>>> It seems this work is yet not committed?!? >>>> >>> Takuya, >>> >>> I see a lot of responses/comments on proposed changes. Was anything >>> decided at the end of it? As far as I can tell, its still not committed >> to >>> the tree. >>> >>> Thanks, >>> Hiren >>> >>> >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52455949.5070501>