Date: Tue, 20 Jan 2009 22:28:28 +0100 From: Christoph Mallon <christoph.mallon@gmx.de> To: Giorgos Keramidas <keramida@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, Tim Kientzle <kientzle@FreeBSD.org> Subject: Re: [PATCH] bsdcpio core dump Message-ID: <497641FC.30209@gmx.de> In-Reply-To: <87skndg0cv.fsf@kobe.laptop> References: <87skndg0cv.fsf@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
Giorgos Keramidas schrieb: > diff -r cb9a95f8dfb3 usr.bin/cpio/cpio.c > --- a/usr.bin/cpio/cpio.c Tue Jan 20 21:45:52 2009 +0200 > +++ b/usr.bin/cpio/cpio.c Tue Jan 20 22:56:48 2009 +0200 > @@ -623,12 +623,12 @@ > r = archive_write_header(cpio->archive, entry); > > if (r != ARCHIVE_OK) > - cpio_warnc(archive_errno(cpio->archive), > + cpio_warnc(0, > "%s: %s", > - destpath, > + srcpath, > archive_error_string(cpio->archive)); > Wouldn't it be better to remove the manually appended error string, i.e. ": %s" ... archive_error_string(), instead of circumventing the generic error reporting magic provided by cpio_warnc()?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?497641FC.30209>