Date: Tue, 20 Jun 2006 12:50:38 -0400 From: John Baldwin <jhb@freebsd.org> To: Adi Pircalabu <apircalabu@bitdefender.com> Cc: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>, Marcus Alves Grando <mnag@freebsd.org>, freebsd-current@freebsd.org, Hajimu UMEMOTO <ume@freebsd.org>, Ivan Voras <ivoras@fer.hr> Subject: Re: Linux-flashplugin7 & rtld - RFC Message-ID: <200606201250.39071.jhb@freebsd.org> In-Reply-To: <20060620181916.732dbc5c@apircalabu.dsd.ro> References: <449015DE.6090407@fer.hr> <200606201002.07695.jhb@freebsd.org> <20060620181916.732dbc5c@apircalabu.dsd.ro>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 20 June 2006 11:19, Adi Pircalabu wrote: > On Tue, 20 Jun 2006 10:02:06 -0400 John Baldwin wrote: > > > On Friday 16 June 2006 14:25, Dmitry Pryanishnikov wrote: > > > > > > Hello! > > > > > > On Sat, 17 Jun 2006, Hajimu UMEMOTO wrote: > > > > dmitry> doesn't crash/hang anything, it just gives the > > > > dmitry> possibility to use this combination. > > > > > > > > This patch is somewhat redundant. Adding > > > > > > > > __weak_reference(dlsym, _dlsym); > > > > > > > > is enough. > > > > > > Indeed, this also works for me. It would be nice to see this > > > trivial addition committed. > > > > I agree. Do you have the __weak_reference() patch handy? > > I know that this patch, by itself, does not break anything in the base > system. It gives the possibility to use native Mozilla-based browsers > with linux-flashplugin7. It eases the task of integrating them. > But not always adding a feature leads to the desired results. Flash7 > DOES hang a lot when used with native Mozilla. Denying this isn't the > right thing to do, it will hit lots of users. > There are not as many reports as someone would expect because the patch > is not applied (yet) mainstream. Usually, if you offer a feature in a > software product, users tend to use it. > In this specific case I'd go for the solution of a separate library > used with LD_PRELOAD by Mozilla proposed by Marcus Alves Grando. > In the end, it's a matter of decision. A separate LD_PRELOAD library for a single weak symbol seems excessive. It also does not enable flash automatically, users still have to conciously choose to install the port. :) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606201250.39071.jhb>