Date: Mon, 27 Nov 2000 12:18:10 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: kris@FreeBSD.org (Kris Kennaway) Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/cron/cron cron.h Message-ID: <200011272018.MAA37340@gndrsh.dnsmgr.net> In-Reply-To: <200011262221.OAA78674@freefall.freebsd.org> from Kris Kennaway at "Nov 26, 2000 02:21:40 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> kris 2000/11/26 14:21:40 PST > > Modified files: > usr.sbin/cron/cron cron.h > Log: > Correct definition of MAXHOSTNAMELEN in ifdef'ed out code I actaully was ignoring these until it hit me, your actually probably breaking the purpose of these. Old systems that didn't have MAXHOSTNAMELEN defined in system headers had a 64 byte length for this. I suspect if one takes this code after your ``Correction'' and compiles it on one of these systems a buffer overflow condition could easily be triggered. I'd rather just see the ifdef'ed code removed so that the compile fails, rather than the compile working and the code failing in strange ways at run time. -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200011272018.MAA37340>