Date: Thu, 11 Mar 2010 11:36:20 -0500
From: Jung-uk Kim <jkim@FreeBSD.org>
To: freebsd-hackers@freebsd.org
Cc: Alexander Best <alexbestms@wwu.de>
Subject: Re: [patch] extending {amd64|i386} cpu info
Message-ID: <201003111136.29999.jkim@FreeBSD.org>
In-Reply-To: <201003110907.04859.jhb@freebsd.org>
References: <permail-201003111343291e86ffa800005d56-a_best01@message-id.uni-muenster.de> <201003110907.04859.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 11 March 2010 09:07 am, John Baldwin wrote: > On Thursday 11 March 2010 8:43:29 am Alexander Best wrote: > > since ed@ noticed that there's no CPUID_TO_STEPPING() macro this > > new patch adds one. i checked and include/specialreg.h is only > > available on amd64, > > i386 > > > and pc98. all the latter does however is: > > > > #include <i386/specialreg.h> > > I don't think we need the CPUID_TO_STEPPING() macro as stepping is > still a simple mask operation. The other macros were added when > the operations became more complicated. Just for the record, I added CPUID_TO_* macros and I absolutely agree that we don't need CPUID_TO_STEPPING(). > I do have a version of your patch I plan to commit soon. Thanks! Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003111136.29999.jkim>