Date: Fri, 30 Nov 2001 19:20:16 +0000 From: Brian Somers <brian@freebsd-services.com> To: Brian Somers <brian@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, freebsd-net@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in.c Message-ID: <200111301920.fAUJKGE02104@hak.lan.Awfulhak.org> In-Reply-To: Message from Brian Somers <brian@FreeBSD.org> of "Fri, 30 Nov 2001 06:00:55 PST." <200111301400.fAUE0tj62293@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> brian 2001/11/30 06:00:55 PST
>
> Modified files:
> sys/netinet in.c
> Log:
> During SIOCAIFADDR, if in_ifinit() fails and we've already added an
> interface address, blow the address away again before returning the
> error.
>
> In in_ifinit(), if we get an error from rtinit() and we've also got
> a destination address, return the error rather than masking EEXISTS.
> Failing to create a host route when configuring an interface should
> be treated as an error.
>
> Revision Changes Path
> 1.61 +39 -24 src/sys/netinet/in.c
It's possible that EEXIST being returned from in_ifinit() should not
be masked at all, except for the ``netmask == 0xffffffff'' case so that
we can't have conflicting interface addresses....
I'm not sure about this though, so I've cc'd freebsd-net.
--
Brian <brian@freebsd-services.com> <brian@Awfulhak.org>
http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111301920.fAUJKGE02104>