Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Oct 2008 03:21:37 +0400
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        Rui Paulo <rpaulo@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   Re: svn commit: r183751 - user/rpaulo/eeemon
Message-ID:  <20081014032137.13da1212.stas@FreeBSD.org>
In-Reply-To: <200810101753.m9AHrQJU097333@svn.freebsd.org>
References:  <200810101753.m9AHrQJU097333@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Tue__14_Oct_2008_03_21_37_+0400_e=7YVXyG+GolOhSa
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, 10 Oct 2008 17:53:26 +0000 (UTC)
Rui Paulo <rpaulo@FreeBSD.org> mentioned:

> Author: rpaulo
> Date: Fri Oct 10 17:53:26 2008
> New Revision: 183751
> URL: http://svn.freebsd.org/changeset/base/183751
>=20
> Log:
>   eeemon is a kernel module for Asus Eee notebooks that allows you to
>   control the fan speed, high/low voltage and it shows the cpu
>   temperature.
>  =20
>   Includes fan control code by "harrow@yandex.ru".
>   Imported from my peronal repo.
>=20

> +
> +static void
> +eeemon_identify(driver_t *driver, device_t parent)
> +{
> +	device_t child;
> +
> +        if (device_find_child(parent, "eeemon", -1) !=3D NULL)
> +		return;
> +
> +	if (eeemon_match() =3D=3D 0)
> +		return;
> +
> +	child =3D BUS_ADD_CHILD(parent, ISA_ORDER_SPECULATIVE, "eeemon", -1);
> +	if (child =3D=3D NULL)
> +		device_printf(parent, "add eeemon child failed\n");
> +

Do we need to attach to a 'real' bus here?

Btw, should it really belong to the kernel code? As all operations are
performed via inb/out it's a clear fit for a userland program.

--=20
Stanislav Sedov
ST4096-RIPE

--Signature=_Tue__14_Oct_2008_03_21_37_+0400_e=7YVXyG+GolOhSa
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAkjz2AEACgkQK/VZk+smlYEz8gCePlaNAkDCwRPLtIzb8qwuYW49
Ib0AoILpnt8pCcWDpJSgjxzGl1Y76FJh
=5QZI
-----END PGP SIGNATURE-----

--Signature=_Tue__14_Oct_2008_03_21_37_+0400_e=7YVXyG+GolOhSa--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081014032137.13da1212.stas>