Date: Wed, 05 Feb 2014 14:38 +0000 From: Max Brazhnikov <makc@freebsd.org> To: gahr@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r342543 - in head/devel/libqxt: . files Message-ID: <2187240.R7uCEPSHNc@mercury.ph.man.ac.uk> In-Reply-To: <20140205134004.GF95905@gahrfit.gahr.ch> References: <201402041452.s14EqQm7008451@svn.freebsd.org> <19602658.DKafOsVslD@mercury.ph.man.ac.uk> <20140205134004.GF95905@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 05 Feb 2014 14:40:04 +0100 Pietro Cerutti wrote: > On 2014-Feb-05, 12:33, Max Brazhnikov wrote: > > On Wed, 05 Feb 2014 10:42:46 +0100 Pietro Cerutti wrote: > > > On 2014-Feb-04, 20:11, Max Brazhnikov wrote: > > > > Hi Pietro, > > > > > > Hi Max, > > > > > > thanks for your valuable feedback! > > > > > > > On Tue, 04 Feb 2014 14:52:26 +0000Tue Feb 4 14:52:26 2014 Pietro Cerutti wrote: > > > > > Author: gahr > > > > > Date: Tue Feb 4 14:52:26 2014 > > > > > New Revision: 342543 > > > > > URL: http://svnweb.freebsd.org/changeset/ports/342543 > > > > > QAT: https://qat.redports.org/buildarchive/r342543/ > > > > > > > > > > Log: > > > > > - STAGE-clean > > > > > - Fix LIB_DEPENDS format > > > > > > > > > > Modified: > > > > > head/devel/libqxt/Makefile > > > > > head/devel/libqxt/files/patch-src-designer_designer.pro > > > > > head/devel/libqxt/pkg-plist > > > > > > > > > > Modified: head/devel/libqxt/Makefile > > > > > ============================================================================== > > > > > --- head/devel/libqxt/Makefile Tue Feb 4 14:42:21 2014 (r342542) > > > > > +++ head/devel/libqxt/Makefile Tue Feb 4 14:52:26 2014 (r342543) > > > > > @@ -10,7 +10,7 @@ DISTNAME= v${PORTVERSION} > > > > > MAINTAINER= gahr@FreeBSD.org > > > > > COMMENT= Extension library for Qt > > > > > > > > > > -LIB_DEPENDS= dns_sd:${PORTSDIR}/net/avahi-libdns > > > > > +LIB_DEPENDS= libdns_sd.so:${PORTSDIR}/net/avahi-libdns > > > > > BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash > > > > > > > > > > USE_BDB= 44+ > > > > > @@ -21,10 +21,10 @@ USE_LDCONFIG= ${PREFIX}/lib/qxt > > > > > > > > > > QT_NONSTANDARD= yes > > > > > HAS_CONFIGURE= yes > > > > > -CONFIGURE_ARGS= -prefix ${PREFIX} \ > > > > > - -libdir ${PREFIX}/lib/qxt \ > > > > > +CONFIGURE_ARGS= -prefix ${STAGEDIR}${PREFIX} \ > > > > > > > > In qmake world the STAGEDIR is called INSTALL_ROOT. Perhaps you could avoid > > > > this and related hacks, if you'd set DESTDIRNAME=INSTALL_ROOT. > > > > > > It is not really clear to me how you think I should fix this. Could you > > > please be more precise please? > > > > Just add 'DESTDIRNAME= INSTALL_ROOT' to Makefile :) > > > > See the patch with all my suggestions and some other improvements: > > http://people.freebsd.org/~makc/patches/libqxt.diff > > Thanks, much appreciated! However, this fails with port test: > > http://people.freebsd.org/~gahr/libqxt.log Ah, I see now. It installs designer plugin to QT_PREFIX, so yes, designer.pro needs simple correction. Fixed in updated patch. Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2187240.R7uCEPSHNc>