Date: Wed, 5 Feb 2014 16:29:21 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Max Brazhnikov <makc@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r342543 - in head/devel/libqxt: . files Message-ID: <20140205152921.GH95905@gahrfit.gahr.ch> In-Reply-To: <2187240.R7uCEPSHNc@mercury.ph.man.ac.uk> References: <201402041452.s14EqQm7008451@svn.freebsd.org> <19602658.DKafOsVslD@mercury.ph.man.ac.uk> <20140205134004.GF95905@gahrfit.gahr.ch> <2187240.R7uCEPSHNc@mercury.ph.man.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--hCH6UO/yhd9rsH1L Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2014-Feb-05, 14:38, Max Brazhnikov wrote: > On Wed, 05 Feb 2014 14:40:04 +0100 Pietro Cerutti wrote: > > On 2014-Feb-05, 12:33, Max Brazhnikov wrote: > > > On Wed, 05 Feb 2014 10:42:46 +0100 Pietro Cerutti wrote: > > > > On 2014-Feb-04, 20:11, Max Brazhnikov wrote: > > > > > Hi Pietro, > > > >=20 > > > > Hi Max, > > > >=20 > > > > thanks for your valuable feedback! > > > >=20 > > > > > On Tue, 04 Feb 2014 14:52:26 +0000Tue Feb 4 14:52:26 2014 Pietro= Cerutti wrote: > > > > > > Author: gahr > > > > > > Date: Tue Feb 4 14:52:26 2014 > > > > > > New Revision: 342543 > > > > > > URL: http://svnweb.freebsd.org/changeset/ports/342543 > > > > > > QAT: https://qat.redports.org/buildarchive/r342543/ > > > > > >=20 > > > > > > Log: > > > > > > - STAGE-clean > > > > > > - Fix LIB_DEPENDS format > > > > > >=20 > > > > > > Modified: > > > > > > head/devel/libqxt/Makefile > > > > > > head/devel/libqxt/files/patch-src-designer_designer.pro > > > > > > head/devel/libqxt/pkg-plist > > > > > >=20 > > > > > > Modified: head/devel/libqxt/Makefile > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > > > --- head/devel/libqxt/Makefile Tue Feb 4 14:42:21 2014 (r34254= 2) > > > > > > +++ head/devel/libqxt/Makefile Tue Feb 4 14:52:26 2014 (r34254= 3) > > > > > > @@ -10,7 +10,7 @@ DISTNAME=3D v${PORTVERSION} > > > > > > MAINTAINER=3D gahr@FreeBSD.org > > > > > > COMMENT=3D Extension library for Qt > > > > > > =20 > > > > > > -LIB_DEPENDS=3D dns_sd:${PORTSDIR}/net/avahi-libdns > > > > > > +LIB_DEPENDS=3D libdns_sd.so:${PORTSDIR}/net/avahi-libdns > > > > > > BUILD_DEPENDS=3D bash:${PORTSDIR}/shells/bash > > > > > > =20 > > > > > > USE_BDB=3D 44+ > > > > > > @@ -21,10 +21,10 @@ USE_LDCONFIG=3D ${PREFIX}/lib/qxt > > > > > > =20 > > > > > > QT_NONSTANDARD=3D yes > > > > > > HAS_CONFIGURE=3D yes > > > > > > -CONFIGURE_ARGS=3D -prefix ${PREFIX} \ > > > > > > - -libdir ${PREFIX}/lib/qxt \ > > > > > > +CONFIGURE_ARGS=3D -prefix ${STAGEDIR}${PREFIX} \ > > > > >=20 > > > > > In qmake world the STAGEDIR is called INSTALL_ROOT. Perhaps you c= ould avoid > > > > > this and related hacks, if you'd set DESTDIRNAME=3DINSTALL_ROOT. > > > >=20 > > > > It is not really clear to me how you think I should fix this. Could= you > > > > please be more precise please? > > >=20 > > > Just add 'DESTDIRNAME=3D INSTALL_ROOT' to Makefile :) > > >=20 > > > See the patch with all my suggestions and some other improvements: > > > http://people.freebsd.org/~makc/patches/libqxt.diff > >=20 > > Thanks, much appreciated! However, this fails with port test: > >=20 > > http://people.freebsd.org/~gahr/libqxt.log >=20 > Ah, I see now. It installs designer plugin to QT_PREFIX, so yes, designer= =2Epro > needs simple correction. Fixed in updated patch. Committed in r342717. Thanks a lot! --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --hCH6UO/yhd9rsH1L Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQJ8BAEBCgBmBQJS8ljMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgietokQAJMmHhpmUoLlI8NuZoNyosUm B6Bp3OyVCBtTX7l0PV0zpRXpm+Cb3HTWvsQU0hHo2fOhANivga/72/VtsmlZfpyg m2bdYabDdILTbCOnHFgmNW+aEQl9nj1gMEjTE02welKV6Szm1Gf24/7RT25Zyrlr ToPtSRRIxEw0Ap/eYj7DbjLryJD/JnDCo24ALDl5VCjd6l5i9fTJpoy8UK70k8u8 mQkhoxfg8q/jfpT5OmoOL9UGXrSiLAl5hs9etfYhAfDQNkKm6sUPk+DvAeFs2+t2 z68sclT5Mpv0iZMZxNKbxV9jgt5j0Mi7Dp5KnEITag9ev/aEeWuarIVrLzBbFCEs At8gtgtUGkBRxe4hkyB3GSOHQUEyLLuQcJVnY5sBKOv7RkvtazREH2NlKTuCjjfq OBi3QssGoDFZJypCVWAiuD/czKoZ6UxsoG3JKEntV+qeEQGZK9iPadTez0uGMS5K lHxJ12G28d5zkPEo0u7wNcrF/M3tvdBDOfU4gP5i22nNqxD1JrBH/LdxTukrxBCh R2MMnOfzrbyL+HfS0u6RA9TcNXyucIxgPwiarTCIkwZ64xsJ2ZFw0M8gfGPd6Fz6 Gekg/OJxeyIVU4I9Ql6yo3jYAP4Wxd6jC9v8OJ+VQ5jGJVelrJUaGSixlbtpdLAM LSlZUNZRnG/4H7q1tWhc =KWDg -----END PGP SIGNATURE----- --hCH6UO/yhd9rsH1L--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140205152921.GH95905>