Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 May 2013 03:35:38 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Niclas Zeising <zeising@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r318897 - head/sysutils/automounter
Message-ID:  <20130524033538.GD48975@FreeBSD.org>
In-Reply-To: <201305231900.r4NJ0LRt034029@svn.freebsd.org>
References:  <201305231900.r4NJ0LRt034029@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 23, 2013 at 07:00:21PM +0000, Niclas Zeising wrote:
> New Revision: 318897
> URL: http://svnweb.freebsd.org/changeset/ports/318897
> 
> @@ -28,6 +26,8 @@ do-install:
>  		@cd ${WRKSRC}; ./install.sh -prefix=${PREFIX}
>  
>  post-install:
> +		@${JOT} -s- -b- 39
>  		@${CAT} ${PKGMESSAGE}
> +		@${JOT} -s- -b- 39

Please don't do this.  If you want to use decorations, include them directly
inside PKGMESSAGE file, and do not pad with empty lines at the top/bottom:
such padding is done by package manager when installing package.  In order
to make installation consistent between port vs. package, we usually write:

  post-install:
	@${ECHO_MSG}
	@${CAT} ${PKGMESSAGE}
	@${ECHO_MSG}

Some of us prefer shorter form:

  post-install:
	@${ECHO_MSG} ; ${CAT} ${PKGMESSAGE} ; ${ECHO_MSG}

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130524033538.GD48975>