Date: Mon, 24 Feb 2014 03:40:01 GMT From: "Craig R. Whipp" <crwhipp@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/186670: [patch] astro/foxtrotgps: wrong paths in pkg-plist causes install to fail Message-ID: <201402240340.s1O3e1ls064859@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/186670; it has been noted by GNATS. From: "Craig R. Whipp" <crwhipp@gmail.com> To: "Florian Degner" <f.degner@gmx.de> Cc: bug-followup@freebsd.org Subject: Re: ports/186670: [patch] astro/foxtrotgps: wrong paths in pkg-plist causes install to fail Date: Sun, 23 Feb 2014 20:32:29 -0700 On Thu, 20 Feb 2014 16:12:05 +0100 "Florian Degner" <f.degner@gmx.de> wrote: > On Thu, 13 Feb 2014 16:44:05 +0100, Craig Whipp <crwhipp@gmail.com> > wrote: > > > Florian, > > > > Can you provide me with more details on what your configuration was > > when you were building this? I've been unable to duplicate the > > error on a 10.0-RELEASE machine, and applying your patch results in > > a failure similar to what you reported in the pr. > > > > What FreeBSD version, output of 'uname -a', any locales configured > > (I see you have a .de top level domain in your email), > > customizations to make.conf, etc. > > > > Thanks, > > Craig > > > Craig, > > there's indeed something non-standard in my /etc/make.conf. The > problem is triggered by compiling astro/foxtrotgps with gcc46. > > When CC=gcc46 ./configure generates different Makefiles. Things break > because it sets DATADIRNAME=share (it's DATADIRNAME=lib when $CC is > "cc" or "clang"). DATADIRNAME is used to determine where the locale > files go: > > % find work -name "Makefile" | xargs grep DATADIRNAME > ... > work/foxtrotgps-1.1.1/po/Makefile:itlocaledir = > $(prefix)/$(DATADIRNAME)/locale > ... > % > > The interesting part is that "share" is actually the correct value. > So the real problem is that we get DATADIRNAME=lib by default. This > in turn can be fixed in a compiler-independent fashion by setting > DATADIRNAME via CONFIGURE_ENV (see attached patch). > > > Cheers, > Flo Florian, This latest patch looks good, thank you. Could a commiter please apply the patch commit this? Thanks, Craig
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402240340.s1O3e1ls064859>