Date: Tue, 3 Feb 2015 18:08:30 +0000 From: "hselasky (Hans Petter Selasky)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <341d558f123153002e8ab049cf1d308f@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-wifan4aus5qtbwh2gnxc-req@FreeBSD.org> References: <differential-rev-PHID-DREV-wifan4aus5qtbwh2gnxc-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
hselasky added a comment. See comments added. INLINE COMMENTS sys/netinet/ip_output.c:129 Because the variable is later on compared to the "mtu" which is also an "int". Else you will get a compile warning about signed comparison mismatch. Same goes for other location where "int" is used. sys/netinet/tcp_lro.c:233 This is a dummy value which should not be used in the new LRO implementation. 65535 is chosen to make the packet drop as invalid in case some code that is not updated, if any, decides to check the "p_len" with "m_pkthdr.len". REVISION DETAIL https://reviews.freebsd.org/D1761 To: hselasky, rmacklem, rrs, glebius, gnn, emaste, imp, adrian, bz, rwatson Cc: freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?341d558f123153002e8ab049cf1d308f>