Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Jun 2003 15:34:47 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        Poul-Henning Kamp <phk@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/vm uma_core.c
Message-ID:  <20030609153323.G36983@root.org>
In-Reply-To: <20030609194039.90E5F37B407@hub.freebsd.org>
References:  <20030609194039.90E5F37B407@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 9 Jun 2003, Poul-Henning Kamp wrote:
>   A white-space nit I noticed.
>
>   Revision  Changes    Path
>   1.56      +1 -1      src/sys/vm/uma_core.c
>
> --- src/sys/vm/uma_core.c:1.55	Sun Apr 27 23:11:32 2003
> +++ src/sys/vm/uma_core.c	Mon Jun  9 12:40:34 2003
> @@ -1843,7 +1843,7 @@
>
>  	/* Do we need to remove from any lists? */
>  	if (slab->us_freecount+1 == zone->uz_ipers) {
> -		LIST_REMOVE(slab, us_link);
> +		LIST_REMOVE(slab,us_link);
>  		LIST_INSERT_HEAD(&zone->uz_free_slab, slab, us_link);
>  	} else if (slab->us_freecount == 0) {
>  		LIST_REMOVE(slab, us_link);

Is that correct style to remove the space after the comma?  The former way
seems more correct.  Also, it differs from the LIST_REMOVE immediately
after.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030609153323.G36983>