Date: Mon, 29 Oct 2001 03:10:06 -0500 (EST) From: "Andrew R. Reiter" <arr@watson.org> To: Luigi Rizzo <rizzo@aciri.org> Cc: Josef Karthauser <joe@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <Pine.NEB.3.96L.1011029030858.35121B-100000@fledge.watson.org> In-Reply-To: <20011029000216.A95875@iguana.aciri.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 29 Oct 2001, Luigi Rizzo wrote: : :I think this is exactly the case where it makes a lot of sense to :declare vars locally to the block: the start of the function is :far away, there is a bunch of small conditionals where each :of them needs to use some temporary variable and those variables :are meant to be used only within the block. : Yes, but nevertheless, style.9 states it should be so. So unless there is a move to change style.9, it's pretty much the answer, no? Cheers, Andrew *-------------................................................. | Andrew R. Reiter | arr@fledge.watson.org | "It requires a very unusual mind | to undertake the analysis of the obvious" -- A.N. Whitehead To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1011029030858.35121B-100000>