Date: Fri, 16 Mar 2012 17:30:20 -0700 (PDT) From: Kevin Oberman <rkoberman@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/166192: vinagre will not connect to system running TightVNC V2 Message-ID: <20120317003020.16F4628435@rogue.comcast.net> Resent-Message-ID: <201203170040.q2H0eADm076530@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166192 >Category: ports >Synopsis: vinagre will not connect to system running TightVNC V2 >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 17 00:40:10 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Kevin Oberman >Release: FreeBSD 9.0-STABLE amd64 >Organization: >Environment: System: FreeBSD rogue.local 9.0-STABLE FreeBSD 9.0-STABLE #1: Thu Mar 1 19:55:43 PST 2012 root@rogue.local:/usr/obj/usr/src/sys/T520 amd64 >Description: When vinagre attempts to connect to a system running TightVNC V2, the connection is immediately closed due to an off-by-one error in src/gvnc.c. This results in sening back the version string without hte terminating newline. It appears that V1 didn'tmind, but V2 declres this a format error. This problem was reported in the Ubuntu forum at: https://bugs.launchpad.net/ubuntu/+source/gtk-vnc/+bug/598597 >How-To-Repeat: Attempt to connect to any TightVNC V2 server with vinagre or any tool using gtk-vnc. >Fix: NOTE: This path is already in the upstream git repo and should appear in the next release. --- src/gvnc.c +++ src/gvnc.c @@ -3543,7 +3543,7 @@ gboolean gvnc_initialize(struct gvnc *gv gvnc->minor = 8; } - snprintf(version, 12, "RFB %03d.%03d\n", gvnc->major, gvnc->minor); + snprintf(version, 13, "RFB %03d.%03d\n", gvnc->major, gvnc->minor); gvnc_write(gvnc, version, 12); gvnc_flush(gvnc); GVNC_DEBUG("Using version: %d.%d", gvnc->major, gvnc->minor); >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120317003020.16F4628435>