Date: Fri, 5 Jul 2013 13:36:58 -0700 From: Navdeep Parhar <np@FreeBSD.org> To: Robert Millan <rmh@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r252491 - head/sys/modules Message-ID: <CAPFoGT9FzGtckvWGhgngmshXJx1vS%2B7uwGgpwUwGouSREAt_ZA@mail.gmail.com> In-Reply-To: <201307012221.r61MLhaM079236@svn.freebsd.org> References: <201307012221.r61MLhaM079236@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a bit excessive. A better option would be to disconnect just the firmware based on the SOURCELESS flag. cxgbe(4) can be built and will work just fine without its firmware. The firmware is bundled with the driver just in case the one already on the card (every card has a firmware on it) is out of date. Regards, Navdeep On Mon, Jul 1, 2013 at 3:21 PM, Robert Millan <rmh@freebsd.org> wrote: > Author: rmh > Date: Mon Jul 1 22:21:42 2013 > New Revision: 252491 > URL: http://svnweb.freebsd.org/changeset/base/252491 > > Log: > Wrap cxgbe declaration around MK_SOURCELESS_UCODE check > > Modified: > head/sys/modules/Makefile > > Modified: head/sys/modules/Makefile > > ============================================================================== > --- head/sys/modules/Makefile Mon Jul 1 22:07:01 2013 (r252490) > +++ head/sys/modules/Makefile Mon Jul 1 22:21:42 2013 (r252491) > @@ -81,7 +81,7 @@ SUBDIR= \ > ${_ctau} \ > ctl \ > ${_cxgb} \ > - cxgbe \ > + ${_cxgbe} \ > ${_cyclic} \ > dc \ > dcons \ > @@ -386,6 +386,10 @@ _cxgb= cxgb > .endif > .endif > > +.if ${MK_SOURCELESS_UCODE} != "no" > +_cxgbe= cxgbe > +.endif > + > .if ${MK_CRYPT} != "no" || defined(ALL_MODULES) > .if exists(${.CURDIR}/../opencrypto) > _crypto= crypto >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPFoGT9FzGtckvWGhgngmshXJx1vS%2B7uwGgpwUwGouSREAt_ZA>