Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Apr 2016 14:49:43 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Garrett Cooper <ngie@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r298491 - stable/10/lib/msun/tests
Message-ID:  <1686086.xOFMeakFfv@ralph.baldwin.cx>
In-Reply-To: <201604222132.u3MLW1jx083176@repo.freebsd.org>
References:  <201604222132.u3MLW1jx083176@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, April 22, 2016 09:32:01 PM Garrett Cooper wrote:
> Author: ngie
> Date: Fri Apr 22 21:32:01 2016
> New Revision: 298491
> URL: https://svnweb.freebsd.org/changeset/base/298491
> 
> Log:
>   MFC r297836:
>   
>   Fix appending -O0 to CFLAGS
>   
>   The previous method would completely nerf CFLAGS once bsd.progs.mk had
>   recursed into the per-PROG logic and make the CFLAGS for tap testcases
>   to -O0, instead of appending to CFLAGS for all of the tap testcases.

Eh, Bryan replied to the commit that put this into HEAD saying it was a
no-op but you didn't reply.  Shouldn't you address that first before MFC'ing?

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1686086.xOFMeakFfv>