Date: Tue, 13 May 2014 06:40:00 GMT From: John Marino <freebsd.contact@marino.st> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/186610: Update port mail/assp to 14040 build Message-ID: <201405130640.s4D6e0Z8041613@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/186610; it has been noted by GNATS. From: John Marino <freebsd.contact@marino.st> To: bug-followup@FreeBSD.org, rnejdl@ringofsaturn.com Cc: Subject: Re: ports/186610: Update port mail/assp to 14040 build Date: Tue, 13 May 2014 08:31:34 +0200 Stumbling upon this .... Comments: 1) The fixes don't include stage support, which is mandatory now 2) The patch set includes several files that aren't actually changed: - files/510.assp.in - files/assp.in - files/patch-assp.pl - files/pkg-install.in 3) the assp.pl patch doesn't end in a new line (see patchset) 4) :U is used, that's got to be changed to :tu now In this case, the use of git hurt. The patchset was blindly generated without noticing either the non-function svnid changes or the missing carriage return. I would fix these problems, then submit a new PR that has the words "support stage" in the title, with a new patch and then ask for the old PR to be closed. I suggest this approach because ports that support stage will be noticed first.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405130640.s4D6e0Z8041613>