Date: Mon, 6 Sep 2010 07:30:12 GMT From: "M. Warner Losh" <imp@bsdimp.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/150235: sysutils/smartmontools build system bug Message-ID: <201009060730.o867UCew071480@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/150235; it has been noted by GNATS.
From: "M. Warner Losh" <imp@bsdimp.com>
To: samm@os2.kiev.ua
Cc: msmith@FreeBSD.org, dougb@FreeBSD.org, wollman@FreeBSD.org,
bug-followup@FreeBSD.org
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Mon, 06 Sep 2010 01:22:03 -0600 (MDT)
In message: <4C841C20.9000301@os2.kiev.ua>
Alex Samorukov <samm@os2.kiev.ua> writes:
: Hi Michael,
:
: I am one of the smartmontools developers and smartmontools port
: maintainer. Smartmontools project implements ciss device support on a
: FreeBSD to obtain smart information from the drives attached to the
: ciss controller. To interact with a ciss devices we are using defines
: from the cissio.h header. Unfortunately this file is not included in
: the /usr/include/sys, and this makes ciss support in smartctl
: dependable on installed kernel sources. This makes a problems for some
: user (see http://www.freebsd.org/cgi/query-pr.cgi?pr=150235). Is it
: possible to install this (and probably other headers) file to the
: /usr/include/sys on a make install process? This will allow to build
: fully functional smartmontools without kernel sources installed.
Hi Alex,
I don't think you'll get very far with Mike Smith. He's a good guy,
but he's at apple now and doesn't seem to do much with the FreeBSD
project these days. I'd try Scott Long or failing that, myself. It
is clearly an oversight that the ioctl interface for the driver is not
installed. We should just install it and be done with it...
Warner
: On 09/06/2010 12:22 AM, Philip Paeps wrote:
: > On 2010-09-06 00:06:54 (+0200), Alex Samorukov<samm@os2.kiev.ua>
: > wrote:
: >
: >> On 09/05/2010 11:44 PM, Doug Barton wrote:
: >>
: >>> On 09/05/2010 12:28 PM, Alex Samorukov wrote:
: >>>
: >>>> Your proposed patch will break smartmontools functionality - thats why
: >>>> i`m not able to accept it.
: >>>>
: >>> It's not at all clear to me why developers@ is cc'ed on these
: >>> messages, but since we are ...
: >>>
: >>> Alex,
: >>>
: >>> Can you please explain why the change Garrett is suggesting will break
: >>> anything? According to his PR all the headers that smartmontools needs
: >>> are included in /usr/include. Is that not the case?
: >>>
: >> It is not the case. cciss.cpp from the sources uses dev/ciss/cissio.h
: >> to
: >> work with cciss devices on FreeBSD. configure script checks if this
: >> file
: >> is exists on the compile time, and if its not - does not compile cciss
: >> support in the smartmontools.
: >> If user will try to use cciss driver in this case - smartmontools will
: >> display an error:
: >>
: >> "CCISS support is not available in this build of smartmontools,\n"
: >> "/usr/src/sys/dev/ciss/cissio.h was not available at build
: >> time.\n\n");
: >>
: > If that interface is public (which it seems to be, from glancing at
: > the file),
: > the header should be installed in /usr/include/sys. There are
: > precedents for
: > this, see<sys/aac_ioctl.h> and<sys/digiio.h> (and presumably others).
: >
: > Any reason not to follow Garrett's suggestion to work with a src
: > developer,
: > perhaps one of the ones listed in the header file you need, to have it
: > put
: > somewhere public?
: >
: > - Philip
: >
: >
:
: --
: This mail is for the internal use of the FreeBSD project committers,
: and as such is private. This mail may not be published or forwarded
: outside the FreeBSD committers' group or disclosed to other
: unauthorised
: parties without the explicit permission of the author(s).
:
1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009060730.o867UCew071480>