Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 May 2014 20:01:39 GMT
From:      Ryan Steinmetz <zi@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/189818: [patch] Do not make unbound's startup conditional on unbound-anchors return code
Message-ID:  <201405142001.s4EK1dBw091030@cgiserv.freebsd.org>
Resent-Message-ID: <201405142010.s4EKA0gH008652@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         189818
>Category:       ports
>Synopsis:       [patch] Do not make unbound's startup conditional on unbound-anchors return code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 14 20:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Ryan Steinmetz
>Release:        
>Organization:
>Environment:
>Description:
Today, unbound-anchor's return code will dictate whether or not unbound is able to start.

The attached patch causes unbound to try to start, even if unbound-anchor's return code is non-zero.

Since unbound-anchor has built-in validation content, unbound's successful startup should not be dependent on unbound-anchor's ability to pull a key from the Internet.

The patch also fixes a trailing whitespace issue.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 354086)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	unbound
 PORTVERSION=	1.4.22
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	dns
 MASTER_SITES=	http://unbound.net/downloads/
 
Index: files/unbound.in
===================================================================
--- files/unbound.in	(revision 354086)
+++ files/unbound.in	(working copy)
@@ -23,7 +23,7 @@
 command="%%PREFIX%%/sbin/unbound"
 extra_commands="reload"
 start_precmd="start_precmd"
-reload_precmd="%%PREFIX%%/sbin/unbound-checkconf >/dev/null" 
+reload_precmd="%%PREFIX%%/sbin/unbound-checkconf >/dev/null"
 
 load_rc_config $name
 
@@ -41,6 +41,7 @@
 		su -m unbound -c "%%PREFIX%%/sbin/unbound-anchor ${unbound_anchorflags}"; \
 	fi &&
 	echo .
+	return 0
 }
 
 run_rc_command "$1"


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405142001.s4EK1dBw091030>