Date: Wed, 14 May 2014 21:00:01 GMT From: Guido Falsi <madpilot@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/189777: [patch] www/codeigniter staging, change url Message-ID: <201405142100.s4EL00as024957@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/189777; it has been noted by GNATS. From: Guido Falsi <madpilot@FreeBSD.org> To: bug-followup@FreeBSD.org, udvzsolt@gmail.com, appleboy.tw@gmail.com Cc: Subject: Re: ports/189777: [patch] www/codeigniter staging, change url Date: Wed, 14 May 2014 22:51:19 +0200 While looking at this patch I noticed it has a problem. The staging conversion is incomplete. The port is still echoing pkg-message by itself, which is unnecessary with staging. The port also echoes various user message during installation, this is wrong when using staging, since thee messages will appear at the wrong time, and will never be seen by people using binary packages. Such messages should be moved to the pkg-message, or, is conditionally shown, a pkg-install script should be created to show them if necessary. Can this patch be fixed keeping all this in mind? The port is also redefining WWWDIR to it's default value, why is this needed? Thanks in advance. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405142100.s4EL00as024957>