Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Mar 2011 13:40:53 GMT
From:      Kalten <kalten@gmx.at>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/155949: firefox 4, WITH_PGO, better Text against DISPLAY problem
Message-ID:  <201103261340.p2QDerQO036198@red.freebsd.org>
Resent-Message-ID: <201103261350.p2QDo6ps085743@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         155949
>Category:       ports
>Synopsis:       firefox 4, WITH_PGO, better Text against DISPLAY problem
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 26 13:50:05 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Kalten
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD freeKwasir.Walhalla.Leben 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
if WITH_PGO=true but DISPLAY not accessible:
---SCHNIPP---
INFO | automation.py | Application pid: 51999
Error: cannot open display: localhost:1001
TEST-UNEXPECTED-FAIL | automation.py | Exited with code 1 during test run
INFO | automation.py | Application ran for: 0:00:00.514949
INFO | automation.py | Reading PID log: /usr/tmp/tmpQW8cK8pidlog
gmake: *** [profiledbuild] Error 1
*** Error code 1

Stop in /usr/ports/www/firefox.
*** Error code 1
---schnapp---

I know: there is a message; but /many/ people will overlook it.
Better text—see patch: (Maybe other text ;-) ) (longer text line does
not work—no possibility to add help text per selectable item?!)
>How-To-Repeat:
cd /usr/ports/www/firefox
option WITH_PGO=true
but DISPLAY not set, or no access. (e.g. ssh to host, then su and portmaster -Da)
make
>Fix:


Patch attached with submission follows:

--- Makefile.orig	2011-03-25 19:34:21.000000000 +0100
+++ Makefile	2011-03-26 13:54:21.000000000 +0100
@@ -51,7 +51,7 @@
 		--disable-ipc
 
 OPTIONS=	DBUS "Enable D-BUS support" on \
-		PGO "Enable Profile-Guided Optimization" off \
+		PGO "Enable ProfileGuidedOptimization (needs X)" off \
 		SMB "Enable smb:// URI support using gnomevfs" off
 
 .include <bsd.port.pre.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103261340.p2QDerQO036198>