Date: Sun, 17 Feb 2013 06:17:06 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Davide Italiano <davide@freebsd.org> Cc: freebsd-current <freebsd-current@freebsd.org>, hiren panchasara <hiren.panchasara@gmail.com> Subject: Re: Running out of bits p_flag (sys/sys/proc.h) Message-ID: <20130217041706.GA2522@kib.kiev.ua> In-Reply-To: <CACYV=-EZ2Sr9STgCnUj%2B-xkWPKPV8Cz4-FhrVMY4v0VNCU_Jvg@mail.gmail.com> References: <CALCpEUF0UwmEa4T3gyAH=YKDYczxZgUjtdjGZikNU4yTd=KKDg@mail.gmail.com> <CACYV=-EZ2Sr9STgCnUj%2B-xkWPKPV8Cz4-FhrVMY4v0VNCU_Jvg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--j+blFMWKY/m72zgp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Feb 17, 2013 at 04:25:22AM +0100, Davide Italiano wrote:
> On Sun, Feb 17, 2013 at 2:58 AM, hiren panchasara
> <hiren.panchasara@gmail.com> wrote:
> > With revision=3D246484, it seems we have hit the limit.
> > At $WORK we have one more flag and to accommodate that we need to bump =
this up.
> >
> > Can p_flag be bumped up to u_long?
> >
> > Index: proc.h
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- proc.h (revision 245937)
> > +++ proc.h (working copy)
> > @@ -497,7 +497,7 @@
> > * The following don't make too much sense.
> > * See the td_ or ke_ versions of the same flags.
> > */
> > - int p_flag; /* (c) P_* flags. */
> > + u_long p_flag; /* (c) P_* flags. */
> > enum {
> > PRS_NEW =3D 0, /* In creation */
> > PRS_NORMAL, /* threads can be run. */
> >
> > Thanks,
> > Hiren
> > _______________________________________________
> > freebsd-current@freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-current
> > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.o=
rg"
>=20
> I see at least two problems here:
> - The change you propose may result in a KBI breakage.
> - sizeof(unsigned long) =3D=3D 4 on some archs, e.g. my i386 Atom, which
> makes the change uneffective.
You are right. The solution is to add one more flags member, e.g.
p_flag2. They are free.
The issue I see with the approach, is with the kinfo and userspace
reporting of the flag2. I think that some uninteresting (for
usermode) flag could be moved to flag2 outright.
--j+blFMWKY/m72zgp
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iQIcBAEBAgAGBQJRIFnBAAoJEJDCuSvBvK1BwgUP/RNb0Uk0IU/YD5U201rdjDZE
OKdtlZKMSjkvRtc2Bmu6gHErJeYcS2evQ1v9bPEevS+38/OcJhbX219W4DKZUTsb
KfJUVFTGL65hz5pgGgttguus6G9TQYmdTq6aJuamFTvzdWXazFGZtb4YcNk6x+Ao
JX8qNGYUaRXg8CvZLtd1KVmlT8qstRswAbRPZopdAlhFK/Q64xAaAvnEHR89xkkw
xGT9IT/ylUnln9Gjb9etMwxCTzHaER2GNufp+vnOWbYKXbWkA4jt1B8+vSwbLWjl
rvLF83HJoju/xp/wrJ3jbrpHG75VF882zX1UE4Uv/3Sv9LrwLbs5fWVSRqciKgZQ
u2PrdIUAq5CqZ9YLNV8+kxq2U0BU9XPY5x3eZ+T++4+bystHKe5lZRT1G5Fd5l0j
uN82XepGzgEhzvDZoJuKec/l2Yn8jLo8GaCiXu/0rp/rC5dpatnBPqVQ9+lAII+2
rQw6KLZI0T8HC/1NKB8GPgzagSzMzxr1SEQUFHIAfvUQHOtEgq1LznukxH0Oz9cG
Yl2uBvd/uG4nXavip4xhyfEocmiYBk0nvqjUYzFsucsngnijfJVQ6adCT4vs5yHo
8ck8xV+6yaVouVKX8jNbuKehS+RPQ1ASmFF3g3pXbQT6AVgbH/+5SfRbYmz6jc05
h/vhc7ZMmZdKSQYVFMB/
=nvSg
-----END PGP SIGNATURE-----
--j+blFMWKY/m72zgp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130217041706.GA2522>