Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Jul 2006 12:23:50 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Oleksandr Tymoshenko <gonzo@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 101195 for review
Message-ID:  <200607101223.51217.jhb@freebsd.org>
In-Reply-To: <200607101131.k6ABV6IS057848@repoman.freebsd.org>
References:  <200607101131.k6ABV6IS057848@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 10 July 2006 07:31, Oleksandr Tymoshenko wrote:
> http://perforce.freebsd.org/chv.cgi?CH=101195
> 
> Change 101195 by gonzo@gonzo_hq on 2006/07/10 11:30:52
> 
> 	o Add mips-specific fields to mdthread struct.
> 
> Affected files ...
> 
> .. //depot/projects/mips2/src/sys/mips/include/proc.h#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/mips2/src/sys/mips/include/proc.h#2 (text+ko) ====
> 
> @@ -37,8 +37,9 @@
>   * Machine-dependent part of the proc structure for AMD64.
>   */
>  struct mdthread {
> -	int	md_spinlock_count;	/* (k) */
> -	register_t md_saved_flags;	/* (k) */
> +	__register_t md_savecrit;	/* critical section saved SR */
> +	void	*md_regs;		/* registers on current frame */
> +	int	md_flags;		/* machine-dependent flags */
>  };

You will still need md_spinlock_count, and please call md_savecrit something 
better like 'md_saved_sr'.  The reason for this is that spinlock_enter/exit 
were added more recently than juli's work.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607101223.51217.jhb>