Date: Sat, 21 Nov 2020 21:43:15 -0700 From: Warner Losh <imp@bsdimp.com> To: Kyle Evans <kevans@freebsd.org> Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org> Subject: Re: Remove ftime() interceptor defs from compiler-rt/FreeBSD Message-ID: <CANCZdfqQhq4Xi2PBWE4V_t_6xALcW1qs7JTqmi1VifrRHO4Vhg@mail.gmail.com> In-Reply-To: <CACNAnaH_LDU0CmpAbnULpr0VGJwFC8=H4DHXh9-qQ_5LfpMn%2BQ@mail.gmail.com> References: <CACNAnaH_LDU0CmpAbnULpr0VGJwFC8=H4DHXh9-qQ_5LfpMn%2BQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 21, 2020, 9:26 PM Kyle Evans <kevans@freebsd.org> wrote: > Hi, > > Can we remove the ftime() interceptor definitions that are FreeBSD > specific in compiler-rt? See: > https://people.freebsd.org/~kevans/intercept.diff -- the very act of > including sys/timeb.h adds build noise from the warning about it being > deprecated, when ftime() is apparently not even intercepted on > FreeBSD: > > #define SANITIZER_INTERCEPT_FTIME \ > (!SI_FREEBSD && !SI_NETBSD && !SI_OPENBSD && SI_POSIX) > Seems legit. Time is marked legacy in xopen. It was only a thing on V7. BSD4 added the replacement gettimeofday(). I'm not seeing any reason to not do this, but I've not looked into this in depth... This hasn't been an important function in a long time. Warner Thanks, > > Kyle Evans > _______________________________________________ > freebsd-toolchain@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to " > freebsd-toolchain-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqQhq4Xi2PBWE4V_t_6xALcW1qs7JTqmi1VifrRHO4Vhg>