Date: Sun, 14 Feb 1999 14:11:24 -0700 From: Nate Williams <nate@mt.sri.com> To: Warner Losh <imp@village.org> Cc: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>, Valentin Shopov <valsho@yahoo.com>, mobile@FreeBSD.ORG, Nate Williams <nate@mt.sri.com> Subject: Re: apm & current Message-ID: <199902142111.OAA22337@mt.sri.com> In-Reply-To: <199902142102.OAA32088@harmony.village.org> References: <199902141646.BAA21353@tasogare.imasy.or.jp> <19990213153958.2977.rocketmail@send1e.yahoomail.com> <199902142102.OAA32088@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> : So, now I'm going to commit version checking code just before > : calling apm_bios_call() in /sys/i386/apm/apm.c into PAO3 CVS repository. > > These patches look basically good. I'll integrate them when I have a > chance. The only issue I have is the plethora of 'options'. There's got to be a better way of configuring the apm device, and adding more options is *NOT* the way to do it. Also, last I looked (quite a while ago, just before APM 1.2 was standardized) the PAO code did not follow the APM specifications when probing. Some of this code was merged into the tree by PHK in Rev 1.55, but I quit arguing about it. This might explain why APM 1.2 commands cause the system to fail, although I'm not sure how they are implemented in the code. I think the patch could make this checking much easier by adding a variable to softc stating the version. That way the check is very simple instead of the complicated way it's done now. In other words, I don't think the patches as sent are very clean, although the functionality in them may be correct. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199902142111.OAA22337>