Date: Wed, 24 Apr 1996 15:14:31 -0700 (MST) From: Terry Lambert <terry@lambert.org> To: msmith@atrad.adelaide.edu.au (Michael Smith) Cc: jmacd@CS.Berkeley.EDU, bde@zeta.org.au, freebsd-hackers@FreeBSD.org Subject: Re: GNU binutils port Message-ID: <199604242214.PAA23109@phaeton.artisoft.com> In-Reply-To: <199604241157.VAA19097@genesis.atrad.adelaide.edu.au> from "Michael Smith" at Apr 24, 96 09:27:21 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > Oh dear.... I can't beleive you're saying this, "They are only warnings". > > > > To me, it has, "My code sucks and I don't care." written all over > > it if you don't fix things so that they compile with no warnings > > and -Wall. Perhaps kernel code is a bit different, but with 4700 > > warnings, I'd be little scared. > > gcc -Wall is _pedantic_. Consider how many of the above are > "Consider parentheses around assignment used as truth value", or > "Integer used as pointer without a cast" (for use of '0' as a [legitimate] > substitute for NULL. > > A pile more would be historic warts where unions were avoided and pointers > to structures were passed around in a known context. Not to mention: if( ret = (x>>8)) "WARNING: ASSIGNMENT IN IF STATEMENT! I AM UNUTTERABLY ANAL!" Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604242214.PAA23109>