Date: Sat, 17 May 2014 10:52:44 GMT From: Olli Hauer <ohauer@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/189881: [patch] net/freeradius3 fix segfault, sort pkg-plist again with changed makeplist Message-ID: <201405171052.s4HAqijP041770@freefall.freebsd.org> Resent-Message-ID: <201405171100.s4HB03b1046257@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 189881 >Category: ports >Synopsis: [patch] net/freeradius3 fix segfault, sort pkg-plist again with changed makeplist >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat May 17 11:00:03 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Olli Hauer >Release: >Organization: >Environment: >Description: FreeRADIUS 3.0.3 segfaults during start Patch obtained from https://github.com/FreeRADIUS/freeradius-server/issues/634 Since the output from `make makeplist' has changed between stagify the port and today reorder pkg-plist again. >How-To-Repeat: $ gdb radiusd > run -X ... Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 801a041c0 (LWP 100840/initial thread)] 0x0000000800dee052 in _talloc_free () from /usr/local/lib/libtalloc.so.2 (gdb) bt #0 0x0000000800dee052 in _talloc_free () from /usr/local/lib/libtalloc.so.2 #1 0x000000080069d859 in cf_item_parse () from /usr/local/lib/freeradius-3.0.3/libfreeradius-server.so #2 0x000000080069e053 in cf_section_parse () from /usr/local/lib/freeradius-3.0.3/libfreeradius-server.so #3 0x000000000041993a in main_config_init () #4 0x0000000000420dc7 in main () (gdb) >Fix: --- freeradius3.diff begins here --- Index: freeradius3/Makefile =================================================================== --- freeradius3/Makefile (revision 354307) +++ freeradius3/Makefile (working copy) @@ -3,6 +3,7 @@ PORTNAME= freeradius DISTVERSION= 3.0.3 +PORTREVISION= 1 CATEGORIES= net MASTER_SITES= ftp://ftp.freeradius.org/pub/freeradius/%SUBDIR%/ \ ftp://ftp.ntua.gr/pub/net/radius/freeradius/%SUBDIR%/ \ Index: freeradius3/files/patch-src__main__mainconfig.c =================================================================== --- freeradius3/files/patch-src__main__mainconfig.c (revision 0) +++ freeradius3/files/patch-src__main__mainconfig.c (working copy) @@ -0,0 +1,14 @@ +Fix FreeRADIUS 3.0.3 crash +https://github.com/FreeRADIUS/freeradius-server/issues/634 +================================================================== +--- ./src/main/mainconfig.c.orig 2014-05-17 11:19:37.000000000 +0200 ++++ ./src/main/mainconfig.c 2014-05-17 11:20:09.000000000 +0200 +@@ -83,7 +83,7 @@ + */ + static char const *localstatedir = NULL; + static char const *prefix = NULL; +-static char my_name; ++static char const *my_name = NULL; + static char const *sbindir = NULL; + static char const *run_dir = NULL; + static char *syslog_facility = NULL; Property changes on: freeradius3/files/patch-src__main__mainconfig.c ___________________________________________________________________ Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Index: freeradius3/pkg-plist =================================================================== --- freeradius3/pkg-plist (revision 354307) +++ freeradius3/pkg-plist (working copy) @@ -832,66 +832,66 @@ %%DATADIR%%/dictionary.zeus %%DATADIR%%/dictionary.zte %%DATADIR%%/dictionary.zyxel -@unexec rmdir "/var/run/radiusd" >/dev/null 2>&1 || : -@unexec rmdir "/var/log/radacct" >/dev/null 2>&1 || : -@dirrm %%DATADIR%% -@dirrm %%EXAMPLESDIR%%/raddb/sites-enabled -@dirrm %%EXAMPLESDIR%%/raddb/sites-available -@dirrm %%EXAMPLESDIR%%/raddb/policy.d -@dirrm %%EXAMPLESDIR%%/raddb/mods-enabled -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/unbound -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/sqlite -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql/extras -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/oracle -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/ndb +@dirrm include/freeradius +@dirrm %%LIBDIR%% +%%PORTDOCS%%@dirrm %%DOCSDIR%%/concepts +%%PORTDOCS%%@dirrm %%DOCSDIR%%/configuration +%%PORTDOCS%%@dirrm %%DOCSDIR%%/deployment +%%PORTDOCS%%@dirrm %%DOCSDIR%%/developer +%%PORTDOCS%%@dirrm %%DOCSDIR%%/modules +%%PORTDOCS%%@dirrm %%DOCSDIR%%/rfc +%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas/ldap +%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas +%%PORTDOCS%%@dirrm %%DOCSDIR%%/vendor +%%PORTDOCS%%@dirrm %%DOCSDIR%% +@dirrm %%EXAMPLESDIR%%/raddb/certs +@dirrm %%EXAMPLESDIR%%/raddb/mods-available +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/attr_filter +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/files +%%RLMPERL%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/perl +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/preprocess +%%RLMPYTHON%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/python +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/mysql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/postgresql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/sqlite +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/mysql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/postgresql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/sqlite +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/mysql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/oracle +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/postgresql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/sqlite +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/mysql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/oracle +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/sqlite +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mssql @dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mysql/extras/wimax @dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mysql/extras @dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mysql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mssql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/ndb +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/oracle +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql/extras +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/sqlite @dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/sqlite -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/postgresql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/oracle -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/mysql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/sqlite -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/oracle -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/mysql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/sqlite -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/postgresql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/mysql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/sqlite -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/postgresql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/mysql -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter @dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql -%%RLMPYTHON%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/python -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/preprocess -%%RLMPERL%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/perl -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/files -@dirrm %%EXAMPLESDIR%%/raddb/mods-config/attr_filter +@dirrm %%EXAMPLESDIR%%/raddb/mods-config/unbound @dirrm %%EXAMPLESDIR%%/raddb/mods-config -@dirrm %%EXAMPLESDIR%%/raddb/mods-available -@dirrm %%EXAMPLESDIR%%/raddb/certs +@dirrm %%EXAMPLESDIR%%/raddb/mods-enabled +@dirrm %%EXAMPLESDIR%%/raddb/policy.d +@dirrm %%EXAMPLESDIR%%/raddb/sites-available +@dirrm %%EXAMPLESDIR%%/raddb/sites-enabled @dirrm %%EXAMPLESDIR%%/raddb @dirrm %%EXAMPLESDIR%% -%%PORTDOCS%%@dirrm %%DOCSDIR%%/vendor -%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas/ldap -%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas -%%PORTDOCS%%@dirrm %%DOCSDIR%%/rfc -%%PORTDOCS%%@dirrm %%DOCSDIR%%/modules -%%PORTDOCS%%@dirrm %%DOCSDIR%%/developer -%%PORTDOCS%%@dirrm %%DOCSDIR%%/deployment -%%PORTDOCS%%@dirrm %%DOCSDIR%%/configuration -%%PORTDOCS%%@dirrm %%DOCSDIR%%/concepts -%%PORTDOCS%%@dirrm %%DOCSDIR%% -@dirrm %%LIBDIR%% -@dirrm include/freeradius +@dirrm %%DATADIR%% @exec if ! [ -d %D/etc/raddb -o -L %D/etc/raddb ]; then cp -RP %D/%%EXAMPLESDIR%%/raddb %D/etc/raddb; echo '===> Bootstrapping default certificates, please wait...'; %D/etc/raddb/certs/bootstrap >/dev/null 2>&1; fi @exec chmod -R g-w,o-rwx %D/etc/raddb @exec if [ ! -d /var/log/radacct ]; then mkdir -p /var/log/radacct; chmod -R go= /var/log/radacct; fi @exec for i in /var/log/radius.log /var/log/radutmp /var/log/radwtmp; do if [ ! -f ${i} ]; then touch ${i}; chmod go= ${i}; fi; done @exec mkdir -p /var/run/radiusd +@unexec rmdir "/var/log/radacct" >/dev/null 2>&1 || : +@unexec rmdir "/var/run/radiusd" >/dev/null 2>&1 || : --- freeradius3.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405171052.s4HAqijP041770>