Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jul 1995 17:42:54 +0400 (MSD)
From:      =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= aka "Andrey A. Chernov, Black Mage" <ache@freebsd.org>
To:        bugs@freebsd.org, Thomas Gellekum <thomas@ghpc8.ihf.rwth-aachen.de>
Subject:   Re: add setlocale() to more(1)
Message-ID:  <cBUZc2m4U1@deep-thought.demos.su>
In-Reply-To: <199507171017.MAA29201@ghpc6.ihf.rwth-aachen.de>; from Thomas Gellekum at Mon, 17 Jul 1995 12:17:43 %2B0200 (MET DST)
References:  <199507171017.MAA29201@ghpc6.ihf.rwth-aachen.de>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <199507171017.MAA29201@ghpc6.ihf.rwth-aachen.de> Thomas
    Gellekum writes:

>Moin,

>I have added a call to setlocale() to more(1) to make it aware of
>different character encodings. The patch is attached below.

>+         setlocale(LC_CTYPE, "");
>+         

Please, never do such things, reasons list:

1) 'More' limited to 8bit chars only, so setlocale here cause
it break all rune (16bit) chars. Supporting of 16bit chars
require total 'more' rewritting.

2) Support for 8bit chars already exists, but activates
differently: all you need to do

		setenv ENABLE_STARTUP_LOCALE

Check /etc/sysconfig for more detailed example.

-- 
Andrey A. Chernov        :
ache@FreeBSD.org         :                   From 33th IETF
FidoNet: 2:5020/230.3    :                      Stockholm
RELCOM Team,FreeBSD Team :



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cBUZc2m4U1>