Date: Thu, 21 Feb 2002 09:52:41 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Julian Elischer <julian@elischer.org> Cc: arch@freebsd.org Subject: RE: that INVARIANT/ucred freeing stuff. Message-ID: <XFMail.020221095241.jhb@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0202202320200.66508-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21-Feb-02 Julian Elischer wrote: > > After talking with a bunch of people there's a genral concensus that we > should just remove the ucred freeing stuff at least in normal builds. I > personally canr't see how it can help in debugging in a real life non > tailored situation to have the ucreds zero'd and it's robbing us of upto > 30% of throughput in some cases. > > I REALLY want to just rip it out! Well, benchmarking debugging code usually isn't a very useful exercise. Why not go for some more optimizations and change KASSSERT() to not do anything for INVARIANTS either? That should add back in some performance as well. </sarcasm> Seriously, getting Giant to do the free is probably biting you and doesn't need to happen 99% of the time. You can push down Giant into crfree() around the call to free() and see if that helps. Who needs debugging anyway, right? We should all just be staring at the code and "seeing" bugs. > julian -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020221095241.jhb>