Date: Fri, 23 Jul 1999 10:59:41 +0930 From: Greg Lehey <grog@lemis.com> To: Julian Elischer <julian@whistle.com> Cc: Dag-Erling Smorgrav <des@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci ide_pci.c Message-ID: <19990723105940.D84734@freebie.lemis.com> In-Reply-To: <Pine.BSF.3.95.990722123505.21011B-100000@current1.whistle.com>; from Julian Elischer on Thu, Jul 22, 1999 at 12:41:43PM -0700 References: <199907221134.EAA03813@freefall.freebsd.org> <Pine.BSF.3.95.990722123505.21011B-100000@current1.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, 22 July 1999 at 12:41:43 -0700, Julian Elischer wrote: > On Thu, 22 Jul 1999, Dag-Erling Smorgrav wrote: > >> des 1999/07/22 04:34:13 PDT >> >> Modified files: (Branch: RELENG_3) >> sys/pci ide_pci.c >> Log: >> Back out previous commit so IDE works again. >> Whatever happened to testing before MFC? >> >> Revision Changes Path >> 1.28.2.2 +99 -124 src/sys/pci/ide_pci.c > > ERK! > I found it.. > - firstpage = DMA_PG_SZ - ((uintptr_t)vaddr & (DMA_PG_SZ)); > + firstpage = DMA_PG_SZ - ((uintptr_t)vaddr & (DMA_PG_SZ - 1)); > > gives the same result for page alligned transfers, but is definitly wrong > for unalligned transfers.. > we must be doing all alligned transfers! > > (I have a rack of 4 machines doing load testing with the bad code and all > working fine!) at a guess, the failure must have been on an access to the > raw device. and.... AHA! the Cx5530 can not do accesses not alligned to > 16 byte boundaries, so we are not testing them.. they get done by PIO, and > not this code. this explains why we can do heavy testing on it and not > see this bug Was this the thing that caused UDMA to fall into a heap on the ground? Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990723105940.D84734>