Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 04 Jan 2015 05:19:09 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 196474] jls causes kernel panic
Message-ID:  <bug-196474-8-3U0uSW1CgW@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-196474-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-196474-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196474

Mateusz Guzik <mjg@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjg@FreeBSD.org

--- Comment #6 from Mateusz Guzik <mjg@FreeBSD.org> ---
So in this case we have:
        error = vfs_setopt_part(opts, "ip4.addr", pr->pr_ip4,
            pr->pr_ip4s * sizeof(*pr->pr_ip4));

where pr_ip4s is -1.

I disagree with the patch.

First off, the bug is in the caller. If anything, bcopy could assert the size
to be positive. Unfortunately it is a md code so the check would have to be
replicated.

Proper fix would return an empty ip table (or no table), but no error.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196474-8-3U0uSW1CgW>