Date: Fri, 18 Jul 2003 13:35:23 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Harti Brandt <brandt@fokus.fraunhofer.de> Cc: hackers@freebsd.org Subject: Re: uma_zalloc() not checking flags Message-ID: <6583.1058528123@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 18 Jul 2003 13:29:44 %2B0200." <20030718132616.G972@beagle.fokus.fraunhofer.de>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030718132616.G972@beagle.fokus.fraunhofer.de>, Harti Brandt write s: > >Given that uma_zalloc() has the same flags as malloc(9) shouldn't it check >these flags like malloc(9) does? I would think we could copy the #ifdef >INVARIANTS section at the beginning of malloc(9) to uma_zalloc_arg(). > >I just found a large number of calls in the ATM code that have just >M_ZERO or even 0 flags. > >Anything against this check? Good point, please implement! -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6583.1058528123>