Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Mar 2009 14:50:49 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 159292 for review
Message-ID:  <200903161450.n2GEonPU038853@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=159292

Change 159292 by hselasky@hselasky_laptop001 on 2009/03/16 14:50:28

	
	USB parallell port driver patch: Don't send ZLP at close.
	Some printers apparently stop working at the first ZLP!
	
	Same patch for USB scanner driver.
	
	In other words: Revert behaviour back to USB1.
	
	Reported by: Alexander Best

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/image/uscanner.c#5 edit
.. //depot/projects/usb/src/sys/dev/usb/serial/ulpt.c#5 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/image/uscanner.c#5 (text+ko) ====

@@ -578,7 +578,6 @@
 		    USCANNER_IFQ_MAXLEN)) {
 			return (ENOMEM);
 		}
-		usb2_fifo_set_close_zlp(fifo, 1);
 	}
 	return (0);
 }

==== //depot/projects/usb/src/sys/dev/usb/serial/ulpt.c#5 (text+ko) ====

@@ -440,7 +440,6 @@
 		}
 		/* set which FIFO is opened */
 		sc->sc_fifo_open[USB_FIFO_TX] = fifo;
-		usb2_fifo_set_close_zlp(fifo, 1);
 	}
 	sc->sc_fflags |= fflags & (FREAD | FWRITE);
 	return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903161450.n2GEonPU038853>