Date: Tue, 3 Feb 2004 12:24:36 +0000 From: Bruce M Simpson <bms@spc.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_icmp.c Message-ID: <20040203122436.GE713@saboteur.dek.spc.org> In-Reply-To: <20040203000622.GA19568@Odin.AC.HMC.Edu> References: <200402022253.i12MrGkO091411@repoman.freebsd.org> <20040202232614.GA24019@Odin.AC.HMC.Edu> <401EE109.D45B606@freebsd.org> <20040203000622.GA19568@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 02, 2004 at 04:06:22PM -0800, Brooks Davis wrote: > I'm not sugguesting caching the ifp. I'm suggesting storing the value > of ifp->if_index. You then use ifnet_byindex to get then the ifp when > needed. You have to check that it isn't NULL, but you should to be > doing that for the ifunit() call as well since it will return NULL and > cause a panic if the admin makes a typo. Good catch. Thanks. BMS --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Comment: '' iD8DBQFAH5MDueUpAYYNtTsRApuAAJ9r4ajOXPKrcWhhY+hNTG1gMhu9vACeL0iG wehT8lDagPRUjrg8n0T5PzA= =iJ77 -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040203122436.GE713>