Date: Tue, 20 May 2008 05:24:04 GMT From: Ryan French <rfrench@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 141885 for review Message-ID: <200805200524.m4K5O49j081191@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=141885 Change 141885 by rfrench@rfrench_mpls on 2008/05/20 05:23:48 Fixed a bug where the ICMP header checksum value was not being computed correctly. Submitted by: Ryan French Affected files ... .. //depot/projects/soc2008/rfrench_mpls/mpls-needle/mpls-needle.c#4 edit .. //depot/projects/soc2008/rfrench_mpls/mpls-needle/mpls-needle.conf#3 edit Differences ... ==== //depot/projects/soc2008/rfrench_mpls/mpls-needle/mpls-needle.c#4 (text+ko) ==== @@ -392,7 +392,7 @@ icmph->icmp_type = icmp_type; icmph->icmp_code = icmp_code; icmph->icmp_cksum = 0; - icmph->icmp_cksum = htons(in_cksum((unsigned short *)icmph, sizeof(icmph))); + icmph->icmp_cksum = in_cksum((unsigned short *)icmph, 4); //set values in mpls header mplsh = htonl(mpls_label << 12 | mpls_qos << 9 | mpls_bos_flag << 8 | mpls_ttl); ==== //depot/projects/soc2008/rfrench_mpls/mpls-needle/mpls-needle.conf#3 (text+ko) ==== @@ -1,3 +1,3 @@ -dst_mac 00:16:d3:fc:c0:b8 ip4 10.1.18.149/10.1.18.162/2/0 icmp 0/0 mpls 55/1/1/3 -dst_mac 00:16:d3:fc:c0:b8 ip4 10.1.18.149/10.1.18.162/2/0 icmp 0/0 mpls 44/1/1/3 -dst_mac 00:16:d3:fc:c0:b8 ip4 10.1.18.149/10.1.18.162/2/0 icmp 0/0 mpls 66/1/1/3 +dst_mac 00:16:d3:fc:c0:b8 ip4 10.1.60.134/10.1.60.123/2/0 icmp 8/0 mpls 55/1/1/3 +dst_mac 00:16:d3:fc:c0:b8 ip4 10.1.60.134/10.1.60.123/2/0 icmp 8/0 mpls 44/1/1/3 +dst_mac 00:16:d3:fc:c0:b8 ip4 10.1.60.134/10.1.60.123/2/0 icmp 8/0 mpls 66/1/1/3
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200805200524.m4K5O49j081191>