Date: Tue, 24 Apr 2012 12:29:40 +0530 From: "Jayachandran C." <jchandra@freebsd.org> To: Jason Evans <jasone@freebsd.org> Cc: freebsd-mips@freebsd.org Subject: Re: svn commit: r234370 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src inclu... Message-ID: <CA%2B7sy7A_ihmfN%2BBFfvjFu93VBiE%2BoBx0b5DUR640SN6YffSGpQ@mail.gmail.com> In-Reply-To: <A0CAC76D-5FD8-4E8C-A825-DD439482ECDC@freebsd.org> References: <201204170722.q3H7ME6A070934@svn.freebsd.org> <CA%2B7sy7D1XLJy8s2i59naqMP=XSL%2BkqXLJg87QonaW9oS22Axmg@mail.gmail.com> <A0CAC76D-5FD8-4E8C-A825-DD439482ECDC@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 24, 2012 at 12:15 PM, Jason Evans <jasone@freebsd.org> wrote: > On Apr 23, 2012, at 11:35 PM, Jayachandran C. wrote: >> On Tue, Apr 17, 2012 at 12:52 PM, Jason Evans <jasone@freebsd.org> wrote= : >>> Author: jasone >>> Date: Tue Apr 17 07:22:14 2012 >>> New Revision: 234370 >>> URL: http://svn.freebsd.org/changeset/base/234370 >> >> [....] >>> +diff --git a/include/jemalloc/jemalloc_FreeBSD.h b/include/jemalloc/je= malloc_FreeBSD.h >>> +new file mode 100644 >>> +index 0000000..2c5797f >>> +--- /dev/null >>> ++++ b/include/jemalloc/jemalloc_FreeBSD.h >>> +@@ -0,0 +1,76 @@ >> [....] >>> ++#ifdef __mips__ >>> ++# =A0define LG_SIZEOF_PTR =A0 =A0 =A0 =A0 =A0 =A0 =A0 2 >>> ++#endif >> >> This breaks 64-bit mips platforms. I have a simple patch that fixes >> this at http://people.freebsd.org/~jchandra/jemalloc.patch >> >> Another possible fix suggested by Juli is to do >> #define =A0LG_SIZEOF_PTR _MIPS_SZPTR >> >> Can you please check-in one of these? =A0If you are busy, I can do the >> check-in if you approve the changes. > > I had planned to do this, based on Juli's suggestion: > >> #ifdef __mips__ >> # =A0if (_MIPS_SZPTR =3D=3D 64) >> # =A0 =A0define LG_SIZEOF_PTR 3 >> # =A0else >> # =A0 =A0define LG_SIZEOF_PTR 2 >> # =A0endif >> #endif > > Feel free to check in whichever approach you feel is cleaner. =A0I can't = test it, so you might as well do the honors. =3D) I seems to have mis-understood Juli's suggestion (sorry). Do I need to update the FREEBSD-diffs file as well? Thanks, JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B7sy7A_ihmfN%2BBFfvjFu93VBiE%2BoBx0b5DUR640SN6YffSGpQ>