Date: Fri, 23 Jul 1999 03:15:01 +0200 (MET DST) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: ghelmer@scl.ameslab.gov (Guy Helmer) Cc: mike@smith.net.au, phk@critter.freebsd.dk, jeremyp@gsmx07.alcatel.com.au, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, jkh@FreeBSD.org Subject: Re: cvs commit: src/release/sysinstall tcpip.c Message-ID: <199907230115.DAA28181@labinfo.iet.unipi.it> In-Reply-To: <Pine.SGI.4.10.9907222159170.347-100000@demios.scl.ameslab.gov> from "Guy Helmer" at Jul 22, 99 10:02:21 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, 23 Jul 1999, Luigi Rizzo wrote: ... > > > deal with the whole mbuf we can move all of the bridging code out of > > > individual drivers as well. > > the reason why i _didn't_ do this is performance. ... > Could we handle this card as a special case (i.e., leave a direct jump > into the bridging code in the NE2000 driver) but handle bridging for all > other cards in ether_input? It certainly would save a lot of code in all > the other drivers. It might require a bit in the mbuf to indicate that > the bridge code has already seen the packet... possibly, yes, but this would only be useful after pulling the bpf stuff out of the drivers. In any case bridging only adds some 5-10 lines of code to each driver (if patches you see are longer this is because there is some interference with BPF and some drivers make the wrong assumption that if we are not using bpf then the card is _not_ in promiscuous mode, and i had to fix this. It certainly requires some mods to drivers, but many have been fixed already, and i have seen Bill Paul is adding bridging support to some of his drivers. So at this point fixing the remaining ones or pulling bridging support out of individual drivers requires approx. the same amount of work. I do agree that it would be cleaner do the common stuff (bpf, bridging, etc.) in ether_input. cheers luigi -----------------------------------+------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) http://www.iet.unipi.it/~luigi/ngc99/ ==== First International Workshop on Networked Group Communication ==== -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907230115.DAA28181>