Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Nov 1999 16:54:31 -0500 (EST)
From:      Bill Fumerola <billf@chc-chimes.com>
To:        Nate Williams <nate@mt.sri.com>
Cc:        Chris Costello <chris@calldei.com>, "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, Chris Costello <chris@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/mergemaster Makefile mergemaster
Message-ID:  <Pine.BSF.4.10.9911011650170.77091-100000@jade.chc-chimes.com>
In-Reply-To: <199911012236.PAA19584@mt.sri.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 1 Nov 1999, Nate Williams wrote:

> Yes he did.  What's the point of emailing out commit logs if everyone
> still has to go look at the diffs.
> 
> Commit email should be self-explanatory and not need to review the diffs
> to see *what* was done.  The diffs are there to see *how* something was
> done.

Nate,

The commitlog said _exactly_ what Chris did. It should be assumed that
he did it like the 30 other Makefiles that do the EXACT SAME FUCKING
THING.

When I upgrade my next port I will use as my commit message:

"First I found out there was a new release of this software, then 
I downloaded it and regenerated the md5 checksum. After trying to
compile it, I found some errors that weren't there before. So I made
local changes and used diff -ruN foo.c.old foo.c to generate a patch
that I placed in patches/. I used cvs add on this patch and then
after tweaking the makefile, I fixed the packing list, boy was that
a pain. After fixing some old errors, I'm now committing this with
cvs ci"

OR

"Upgrade to x.y, make associated changes"

I've done the latter ever since I got my commit bit.

I am amazed at the petty shit that this list has sunk to bitching about.

-- 
- bill fumerola - billf@chc-chimes.com - BF1560 - computer horizons corp -
- ph:(800) 252-2421 - bfumerol@computerhorizons.com - billf@FreeBSD.org  -






To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9911011650170.77091-100000>