Date: Mon, 11 Jun 2007 14:50:26 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: sam@errno.com Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net80211 ieee80211_radiotap.h Message-ID: <20070611.145026.-1303462192.imp@bsdimp.com> In-Reply-To: <466DAD3E.7090106@errno.com> References: <200706111934.l5BJYr9O095451@repoman.freebsd.org> <466DAD3E.7090106@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <466DAD3E.7090106@errno.com>
Sam Leffler <sam@errno.com> writes:
: Warner Losh wrote:
: > imp 2007-06-11 19:34:53 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/net80211 ieee80211_radiotap.h
: > Log:
: > Prefer __packed to __attribute__((__packed__)).
: >
: > OK'd by sam@ months ago...
: >
: > Revision Changes Path
: > 1.9 +1 -1 src/sys/net80211/ieee80211_radiotap.h
: > http://cvsweb.FreeBSD.org/src/sys/net80211/ieee80211_radiotap.h.diff?r1=1.8&r2=1.9
: >
: >
: This file is included in user code. Is __packed commonly visible?
Yes. Nothing that includes any kernel file could not have it defined
and visible, afaik.
: FWIW I've avoided tweaking this file as much as possible because of it's
: shared heritage w/ netbsd.
I'll be happy to revert it. I'm pretty sure the last time we talked
about it you said it was OK, however. Maybe my memory is faulty, or
maybe things have changed. I'll back it out if either of those are
the case if you think it is bad...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070611.145026.-1303462192.imp>