Date: Tue, 7 Dec 2010 12:25:28 +0100 From: Ivan Voras <ivoras@freebsd.org> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <AANLkTi=TiqtFjjVGeheWV1yTq76jke9axbz2bvm4bQph@mail.gmail.com> In-Reply-To: <20101207102104.GD1700@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> <20101206192238.GB1936@garage.freebsd.pl> <AANLkTine9rGq_cM4ruFXYq=-F7cMXcQAr-zKHuWoQs2z@mail.gmail.com> <20101206195327.GD1936@garage.freebsd.pl> <AANLkTinUjzrUWc9Xn-iQYmSMZKVxCw9G-0HH868YonMy@mail.gmail.com> <20101207102104.GD1700@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7 December 2010 11:21, Pawel Jakub Dawidek <pjd@freebsd.org> wrote: > PS. Do you know your change breaks all current ZFS installation if > stripesize is defined for a provider? > > =C2=A0 =C2=A0 =C2=A0 =C2=A0# zpool create tank ada0 > =C2=A0 =C2=A0 =C2=A0 =C2=A0(upgrade FreeBSD so that ada0 now reports 4kB = stripesize) > =C2=A0 =C2=A0 =C2=A0 =C2=A0# zpool import tank > =C2=A0 =C2=A0 =C2=A0 =C2=A0cannot import 'tank': invalid vdev configurati= on Actually I did test the patch and, similar to the Solaris people, found that ZFS records ashift in metadata and uses the recorded one instead of hardcoded / detected one. What you found here really shouldn't happen. Are you sure only stripesize was increased in your case, not sectorsize? > So you change was not only poorly thought out and not reviewed, but also > not even minimally tested. Before we go any further, back it out. This actually is the first problem that requires backing it out. I will do = it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=TiqtFjjVGeheWV1yTq76jke9axbz2bvm4bQph>