Date: Tue, 12 May 2009 00:40:35 GMT From: Lucius Windschuh <lwindschuh@googlemail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: usb/134476: [usb2] [umass] [quirk] Add quirk for Cypress xx6830xx Message-ID: <200905120040.n4C0eZdL003284@www.freebsd.org> Resent-Message-ID: <200905120050.n4C0o1MB002759@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 134476
>Category: usb
>Synopsis: [usb2] [umass] [quirk] Add quirk for Cypress xx6830xx
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-usb
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue May 12 00:50:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Lucius Windschuh
>Release: CURRENT@r191999
>Organization:
>Environment:
FreeBSD CURRENT 8.0-CURRENT FreeBSD 8.0-CURRENT #54 r191999M: Tue May 12 01:41:57 CEST 2009 root@current:/usr/obj/usr/src/sys/CURRENT i386
>Description:
Attaching some external disk with a gjournaled UFS2 to my FreeBSD produces these errors:
umass1: Get Max Lun not supported (USB_ERR_STALLED)
[...]
(da1:umass-sim1:1:0:0): SYNCHRONIZE CACHE(10). CDB: 35 0 0 0 0 0 0 0 0 0
(da1:umass-sim1:1:0:0): CAM Status: SCSI Status Error
(da1:umass-sim1:1:0:0): SCSI Status: Check Condition
(da1:umass-sim1:1:0:0): ILLEGAL REQUEST asc:20,0
(da1:umass-sim1:1:0:0): Invalid command operation code
(da1:umass-sim1:1:0:0): Unretryable error
GEOM_JOURNAL: BIO_FLUSH not supported by da1s1e.
(da1:umass-sim1:1:0:0): SYNCHRONIZE CACHE(10). CDB: 35 0 0 0 0 0 0 0 0 0
(da1:umass-sim1:1:0:0): CAM Status: SCSI Status Error
(da1:umass-sim1:1:0:0): SCSI Status: Check Condition
(da1:umass-sim1:1:0:0): ILLEGAL REQUEST asc:20,0
(da1:umass-sim1:1:0:0): Invalid command operation code
(da1:umass-sim1:1:0:0): Unretryable error
GEOM_JOURNAL: BIO_FLUSH not supported by da1s1a.
>How-To-Repeat:
Put a gjournal on an external disk with a Cypress chipset and use it.
>Fix:
Attached patch.
Patch attached with submission follows:
Index: sys/dev/usb/storage/umass.c
===================================================================
--- sys/dev/usb/storage/umass.c (Revision 191999)
+++ sys/dev/usb/storage/umass.c (Arbeitskopie)
@@ -427,6 +427,10 @@
UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
FORCE_SHORT_INQUIRY | NO_START_STOP | IGNORE_RESIDUE
},
+ {USB_VENDOR_CYPRESS, USB_PRODUCT_CYPRESS_XX6830XX, RID_WILDCARD,
+ UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
+ NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE
+ },
{USB_VENDOR_DESKNOTE, USB_PRODUCT_DESKNOTE_UCR_61S2B, RID_WILDCARD,
UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
NO_QUIRKS
Index: sys/dev/usb/usbdevs
===================================================================
--- sys/dev/usb/usbdevs (Revision 191999)
+++ sys/dev/usb/usbdevs (Arbeitskopie)
@@ -1106,6 +1106,7 @@
product CYPRESS FMRADIO 0x1002 FM Radio
product CYPRESS USBRS232 0x5500 USB-RS232 Interface
product CYPRESS SLIM_HUB 0x6560 Slim Hub
+product CYPRESS XX6830XX 0x6830 PATA Storage Device
/* Daisy Technology products */
product DAISY DMC 0x6901 USB MultiMedia Reader
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905120040.n4C0eZdL003284>