Date: Wed, 21 Dec 2005 11:15:38 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d Makefile Message-ID: <20051221091538.GC55142@ip.net.ua> In-Reply-To: <43A91330.2000704@FreeBSD.org> References: <200512202056.jBKKuLQO034591@repoman.freebsd.org> <20051221080846.GA55142@ip.net.ua> <43A91330.2000704@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--8X7/QrJGcKSMr1RN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 21, 2005 at 12:32:48AM -0800, Doug Barton wrote: > Ruslan Ermilov wrote: > >On Tue, Dec 20, 2005 at 08:56:21PM +0000, Doug Barton wrote: > >>dougb 2005-12-20 20:56:21 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: (Branch: RELENG_6) > >> etc/rc.d Makefile=20 > >> Log: > >> MFC 1.56, make install of sshd conditional on NO_OPENSSH > >> =20 > >> Revision Changes Path > >> 1.53.2.4 +6 -1 src/etc/rc.d/Makefile > >> > >The full condition, to match the sources, would be: > > > >.if !defined(NO_CRYPT) && !defined(NO_OPENSSL) && !defined(NO_OPENSSH) > > > >That's how we get to compile secure/usr.sbin/sshd/. >=20 > Well, I wondered about that, but I didn't make the original change, so I= =20 > just MFC'ed what was there. If you want to update the Makefile in HEAD I'= ve=20 > no objection, or if you think it's really important, I'll be glad to do i= t=20 > as well. >=20 Please do it while you're at it. > Personally, while I remember the support problems that not having all tho= se=20 > tests caused back in the day, I always thought that it was providing too= =20 > big a crutch. However, that's just grousing, and I've no objection to=20 > updating rc.d/Makefile if you think we need to. >=20 Well, if the installation is conditional, the condition should be correct. Otherwise, it should be made unconditional. :-) Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --8X7/QrJGcKSMr1RN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDqR06qRfpzJluFF4RAhZhAJoD4YODiSPeVq/O9Ap+UNGNvskFQQCfUCBB xupjBOIo5MaYAG3VI7uwYds= =o1uf -----END PGP SIGNATURE----- --8X7/QrJGcKSMr1RN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051221091538.GC55142>