Date: Wed, 24 Oct 2007 21:44:28 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: David Xu <davidxu@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Julian Elischer <julian@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_fork.c Message-ID: <20071025044428.GS33488@elvis.mu.org> In-Reply-To: <47200242.4050403@freebsd.org> References: <200710231754.l9NHsGLH090312@repoman.freebsd.org> <471FF2BE.9000204@freebsd.org> <20071025022607.GQ33488@elvis.mu.org> <47200064.9050403@freebsd.org> <20071025023418.GR33488@elvis.mu.org> <47200242.4050403@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* David Xu <davidxu@FreeBSD.org> [071024 19:40] wrote: > Alfred Perlstein wrote: > > >>thread_suspend_check() with SINGLE_BOUNDARY is used is only called > >>in userret() where I don't think any code is still using the p_fd. > > > > > >This is not an acceptable solution as it will deadlock unless all > >threads exit the kernel. > > > > Where is deadlock ? thread_single(SINGLE_BOUNDARY) does not suspend > sleeping thread, it will interrupt it. If it does, it will give awful semantics, it's better to just disallow this action with threads until the code is fixed. -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071025044428.GS33488>