Date: Tue, 15 Dec 2009 10:10:36 -0800 From: Tim Kientzle <kientzle@freebsd.org> To: Baptiste Daroussin <baptiste.daroussin@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: Small patches for pkg_add Message-ID: <4B27D11C.50206@freebsd.org> In-Reply-To: <20091215145243.GF1016@wicklow.lan> References: <20091215145243.GF1016@wicklow.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
Baptiste Daroussin wrote: > I've written a small patch for pkg_install that removes the system call to tar > in pkg_add command replacing it by some libarchive code. Great! This looks good, but I have a few suggestions: You should be a little more careful about error handling. In particular, after any failure, archive_error_string(a) will hold an error message that you probably want to print out for the user's benefit. In particular, you should print the error message after a failure of archive_read_open_filename(), archive_read_extract(), or archive_read_next_header(). You can also simplify slightly by omitting calls to archive_read_data_skip() (it's never needed). Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B27D11C.50206>