Date: Mon, 29 Oct 2001 11:29:28 +0000 From: Josef Karthauser <joe@tao.org.uk> To: "Andrew R. Reiter" <arr@watson.org> Cc: Josef Karthauser <joe@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <20011029112928.C867@tao.org.uk> In-Reply-To: <Pine.NEB.3.96L.1011029000720.32447A-100000@fledge.watson.org>; from arr@watson.org on Mon, Oct 29, 2001 at 12:11:24AM -0500 References: <200110290441.f9T4fSY68423@freefall.freebsd.org> <Pine.NEB.3.96L.1011029000720.32447A-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--8NvZYKFJsRX2Djef Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 29, 2001 at 12:11:24AM -0500, Andrew R. Reiter wrote: >=20 > Sorry to reply to ipfw.c commits this way, but while there have been style > fixes, I don't think all have been fixed. For example, in show_ipfw(), > there is char timestr[30]; which is found in the middle of an if block. > IIRC, isn't this a style problem as well? Also, I would imagine that it's > just poor design to have to declare variables in the middle of a block, > whether it be an if-block, for-block, etc.. >=20 Maybe :) Feel free to commit fixes to -current if you care :). The style changes I've made to -current are ones that were already in the -stable version, but would have been backed out during MFC. There are many many more improvements that could be made, but my goal is to sync the code bases as much as possible so that the "normal" development process can continue - I'm not an ipfw developer myself. Joe --8NvZYKFJsRX2Djef Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjvdPZgACgkQXVIcjOaxUBa8aQCgmCDm7XHMq0Vbjn1vsU2XqmU4 VtgAoKbApr2mYx4Hc/ln/E4w7lGWmHTA =BDzD -----END PGP SIGNATURE----- --8NvZYKFJsRX2Djef-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011029112928.C867>