Date: Tue, 24 Jul 2007 21:58:45 +0200 From: Erwin Lansing <erwin@FreeBSD.org> To: Paul Schmehl <pauls@utdallas.edu> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: How do you remove unneeded patch files? Message-ID: <20070724195845.GA37472@droso.net> In-Reply-To: <CBBCC6FE2F582A58EE7F95CD@utd59514.utdallas.edu> References: <CBBCC6FE2F582A58EE7F95CD@utd59514.utdallas.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--Y9MYNmSb6ticsAhO Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 24, 2007 at 02:41:04PM -0500, Paul Schmehl wrote: > I'm working on a port upgrade. The existing port has a number of patch= =20 > files in FILESDIR that are no longer needed. (The changes they made hav= e=20 > been incorporated into the distro.) What's the appropriate way to submi= t=20 > those changes? Normally, a send-pr submission will contain the patches = for=20 > existing port files. There is no patch for these. They need to be remo= ved. >=20 > I could do this: diff -Naur files/original_patch_file files/empty_file,= but=20 > I don't know if that removes the file or simply replaces it with an empt= y=20 > one. >=20 The result of using that patch would be an empty file. This is also alright to submit it that way, but as a courtesy to the committer (and also to make sure he doesn't forget) it would be good to mention in the PR that file/xyz and files/abc should be removed completely. Cheers, -erwin --=20 Erwin Lansing http://droso.org Security is like an onion. (o_ _o) It's made up of several layers \\\_\ /_/// erwin@FreeBSD.org And it makes you cry. <____) (____> erwin@aauug.dk --Y9MYNmSb6ticsAhO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGpln1qy9aWxUlaZARArFXAKCJvyGqSdxpUUxUbW/gWQbOSo/EaACcCboe GVUqoqEIsmFgmC+ZGp3kvV8= =K5HO -----END PGP SIGNATURE----- --Y9MYNmSb6ticsAhO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070724195845.GA37472>