Date: Tue, 15 Dec 2009 18:14:38 +0000 From: Baptiste Daroussin <baptiste.daroussin@gmail.com> To: freebsd-current@freebsd.org Subject: Re: Small patches for pkg_add Message-ID: <ed7b1c610912151014h54df92c2gdd357476e5e36751@mail.gmail.com> In-Reply-To: <4B27D11C.50206@freebsd.org> References: <20091215145243.GF1016@wicklow.lan> <4B27D11C.50206@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Great! > > This looks good, but I have a few suggestions: > > You should be a little more careful about error handling. > In particular, after any failure, archive_error_string(a) > will hold an error message that you probably want to > print out for the user's benefit. > > In particular, you should print the error message > after a failure of archive_read_open_filename(), > archive_read_extract(), or archive_read_next_header(). > > You can also simplify slightly by omitting calls to > archive_read_data_skip() (it's never needed). > > Tim > Thanks, I'll do that FYI I opened a git for that work : http://git.etoilebsd.net/cgit/pkg_install/ I'll add what you advice me todo regards, Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ed7b1c610912151014h54df92c2gdd357476e5e36751>